Revert command substitution workaround and add agent permission docs#147
Merged
sebastientaggart merged 2 commits intoApr 22, 2026
Merged
Conversation
Member
Author
Review SummaryVerdict: APPROVE Findings
Otherwise the PR is clean:
|
Member
Author
Review SummaryVerdict: APPROVE FindingsNo issues found. Code looks correct and follows project conventions. What was checked:
|
sebastientaggart
deleted the
feature/145-fix-start-reprompt-and-deploy-tags
branch
April 22, 2026 23:43
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the #137 two-step
git rev-parseworkaround in submit-for-review, restoring the simplercd "$(git rev-parse --show-toplevel)"one-liner. Instead of working around agent-specific permission prompts in the skills, add an "Agent tips and tweaks" section to the docs that explains how to configure each agent's permission system (Claude Codepermissions.allow, Cursor, Codex, Gemini).This gets Code Cannon out of the business of agent-specific workarounds in skill instructions — users configure their agent once and all skills benefit.
Issue #145